[patch] 2.5.65-mjb1: lkcd: fix dump_fmt.c for !CONFIG_SMP

From: Adrian Bunk (bunk@fs.tum.de)
Date: Wed Mar 19 2003 - 03:30:25 EST

Next message: george anzinger: "Re: [PATCH] fix nanosleep() granularity bumps"
Previous message: george anzinger: "Re: [PATCH] limits on SCHED_FIFO tasks"
In reply to: Martin J. Bligh: "2.5.65-mjb1 (scalability / NUMA patchset)"
Next in thread: Martin J. Bligh: "Re: [patch] 2.5.65-mjb1: lkcd: fix dump_fmt.c for !CONFIG_SMP"
Reply: Martin J. Bligh: "Re: [patch] 2.5.65-mjb1: lkcd: fix dump_fmt.c for !CONFIG_SMP"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Mar 18, 2003 at 12:22:43AM -0800, Martin J. Bligh wrote:
>...
> lkcd LKCD team
> Linux kernel crash dump support
>...

I got the following compile error for !CONFIG_SMP:

<-- snip -->

...
gcc-2.95 -Wp,-MD,drivers/dump/.dump_fmt.o.d -D__KERNEL__ -Iinclude
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6
-Iinclude/asm-i386/mach-default -fomit-frame-pointer -nostdinc
-iwithprefix include -DKBUILD_BASENAME=dump_fmt -DKBUILD_MODNAME=dump
-c -o drivers/dump/dump_fmt.o drivers/dump/dump_fmt.c
drivers/dump/dump_fmt.c:171: macro `__dump_save_other_cpus' used without args
make[2]: *** [drivers/dump/dump_fmt.o] Error 1

<-- snip -->

Trivial fix:

--- linux-2.5.65-mjb1/include/linux/dump.h~ 2003-03-18 17:09:59.000000000 +0100
+++ linux-2.5.65-mjb1/include/linux/dump.h 2003-03-19 09:24:43.000000000 +0100
@@ -343,7 +343,7 @@
#ifdef CONFIG_SMP
extern void __dump_save_other_cpus(void);
#else
-#define __dump_save_other_cpus(void)
+#define __dump_save_other_cpus()
#endif

#endif /* __KERNEL__ */

cu
Adrian

"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: george anzinger: "Re: [PATCH] fix nanosleep() granularity bumps"
Previous message: george anzinger: "Re: [PATCH] limits on SCHED_FIFO tasks"
In reply to: Martin J. Bligh: "2.5.65-mjb1 (scalability / NUMA patchset)"
Next in thread: Martin J. Bligh: "Re: [patch] 2.5.65-mjb1: lkcd: fix dump_fmt.c for !CONFIG_SMP"
Reply: Martin J. Bligh: "Re: [patch] 2.5.65-mjb1: lkcd: fix dump_fmt.c for !CONFIG_SMP"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:26 EST