Re: [Linux-ATM-General] Re: 2.5.64-mm8: drivers/atm/idt77252.c doesn't compile

From: chas williams (chas@locutus.cmf.nrl.navy.mil)
Date: Mon Mar 17 2003 - 10:43:15 EST


In message <20030316154414.GB10253@fs.tum.de>,Adrian Bunk writes:
> tx_inuse was removed from struct atm_vcc in include/linux/atmdev.h but
> drivers/atm/idt77252.c still needs it:

it doesnt need it -- it just needs to use the right member. the following
patch should fix the current errors. i missed these bits during my
earlier changes.

Index: linux/net/sched/sch_atm.c
===================================================================
RCS file: /home/chas/CVSROOT/linux/net/sched/sch_atm.c,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -r1.1.1.1 -r1.2
--- linux/net/sched/sch_atm.c 20 Feb 2003 13:46:33 -0000 1.1.1.1
+++ linux/net/sched/sch_atm.c 11 Mar 2003 15:20:25 -0000 1.2
@@ -508,7 +508,7 @@
                         ATM_SKB(skb)->vcc = flow->vcc;
                         memcpy(skb_push(skb,flow->hdr_len),flow->hdr,
                             flow->hdr_len);
- atomic_add(skb->truesize,&flow->vcc->tx_inuse);
+ atomic_add(skb->truesize,&flow->vcc->sk->wmem_alloc);
                         ATM_SKB(skb)->iovcnt = 0;
                         /* atm.atm_options are already set by atm_tc_enqueue */
                         (void) flow->vcc->send(flow->vcc,skb);
Index: linux/net/atm/pppoatm.c
===================================================================
RCS file: /home/chas/CVSROOT/linux/net/atm/pppoatm.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 pppoatm.c
--- linux/net/atm/pppoatm.c 20 Feb 2003 13:46:30 -0000 1.1.1.1
+++ linux/net/atm/pppoatm.c 15 Mar 2003 14:35:27 -0000
@@ -231,7 +231,7 @@
                 kfree_skb(skb);
                 return 1;
         }
- atomic_add(skb->truesize, &ATM_SKB(skb)->vcc->tx_inuse);
+ atomic_add(skb->truesize, &ATM_SKB(skb)->vcc->sk->wmem_alloc);
         ATM_SKB(skb)->iovcnt = 0;
         ATM_SKB(skb)->atm_options = ATM_SKB(skb)->vcc->atm_options;
         DPRINTK("(unit %d): atm_skb(%p)->vcc(%p)->dev(%p)\n",
Index: linux/drivers/atm/idt77252.c
===================================================================
RCS file: /home/chas/CVSROOT/linux/drivers/atm/idt77252.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 idt77252.c
--- linux/drivers/atm/idt77252.c 20 Feb 2003 13:45:03 -0000 1.1.1.1
+++ linux/drivers/atm/idt77252.c 16 Mar 2003 13:17:56 -0000
@@ -730,7 +730,7 @@
                 struct atm_vcc *vcc = vc->tx_vcc;
 
                 vc->estimator->cells += (skb->len + 47) / 48;
- if (atomic_read(&vcc->tx_inuse) > (vcc->sk->sndbuf >> 1)) {
+ if (atomic_read(&vcc->sk->wmem_alloc) > (vcc->sk->sndbuf >> 1)) {
                         u32 cps = vc->estimator->maxcps;
 
                         vc->estimator->cps = cps;
@@ -2025,7 +2025,7 @@
                 atomic_inc(&vcc->stats->tx_err);
                 return -ENOMEM;
         }
- atomic_add(skb->truesize + ATM_PDU_OVHD, &vcc->tx_inuse);
+ atomic_add(skb->truesize + ATM_PDU_OVHD, &vcc->sk->wmem_alloc);
         ATM_SKB(skb)->iovcnt = 0;
 
         memcpy(skb_put(skb, 52), cell, 52);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:20 EST