Re: Complete support PC-9800 for 2.5.64-ac4 (11/11) SCSI

From: James Bottomley (James.Bottomley@steeleye.com)
Date: Sun Mar 16 2003 - 13:54:43 EST


On Sun, 2003-03-16 at 12:36, Geert Uytterhoeven wrote:
> Actually, it was my suggestion to remove the dereference for PIO accesses. In
> that case SASR contains the I/O port register.

There's still something wrong with the implementation in this patch.
For non PIO SASR is defined as volatile unsigned char *SASR. Its access
has gone from being outb(n, *regs.SASR) to outb(n, regs.SASR). What
expansion can outb have on m68k and MIPS that makes this change
idempotent?

James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Mar 23 2003 - 22:00:18 EST