Re: [PATCH] Another bitop on boolean in pnpbios

From: John Levon (levon@movementarian.org)
Date: Mon Mar 03 2003 - 15:25:34 EST


On Mon, Mar 03, 2003 at 01:56:43AM -0800, William Lee Irwin III wrote:

> pnpbios_is_static() could probably use the same treatment.

Sure. Linus, at least one of the below actually broke...

regards
john

--- linux-linus/include/linux/pnpbios.h 2003-01-13 22:43:41.000000000 +0000
+++ linux/include/linux/pnpbios.h 2003-03-03 20:28:43.000000000 +0000
@@ -85,8 +85,8 @@
 #define PNPBIOS_BOOTABLE 0x0010
 #define PNPBIOS_DOCK 0x0020
 #define PNPBIOS_REMOVABLE 0x0040
-#define pnpbios_is_static(x) ((x)->flags & 0x0100) == 0x0000
-#define pnpbios_is_dynamic(x) (x)->flags & 0x0080
+#define pnpbios_is_static(x) (((x)->flags & 0x0100) == 0x0000)
+#define pnpbios_is_dynamic(x) ((x)->flags & 0x0080)
 
 /* 0x8000 through 0xffff are OEM defined */
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:22 EST