Re: [patch] remap-file-pages-2.5.63-A0

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Mar 03 2003 - 11:50:34 EST


On Mon, 3 Mar 2003, Ingo Molnar wrote:
>
> the attached patch, against BK-curr, is a preparation to make
> remap_file_pages() usable on swappable vmas as well. When 'swapping out'
> shared-named mappings the page offset is written into the pte.
>
> it takes one bit from the swap-type bits, otherwise it does not change the
> pte layout - so it should be easy to adapt any other architecture to this
> change as well. (this patch does not introduce the protection-bits-in-pte
> approach used in my previous patch.)

One question: Why?

What's wrong with just using the value we use now (0), and just
calculating the page from the vma/offset information? Why hide the offset
in the page tables, when there is no need for it?

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:21 EST