Re: mkdep patch in 2.4.21-pre4-ac7 breaks pci/drivers

From: Pavel Roskin (proski@gnu.org)
Date: Mon Mar 03 2003 - 03:32:55 EST


Hello!

On Sat, 1 Mar 2003, Horst von Brand wrote:

> Pavel Roskin <proski@gnu.org> said:
> > If I compile linux 2.4.21-pre4-ac7, then run "make depend" and "make
> > clean", then "make bzImage" fails in pci/drivers:
>
> make drivers/pci/gen-devlist; pushd drivers/pci; ./gen-devlist < pci.ids; popd
>
> Needed for all 2.4.x I've seen (lately at least).

That shouldn't be needed unless you skip "make depend" completely or do
something else wrong, or your "make" is buggy. It shouldn't be necessary.

names.o depends on devlist.h explicitly in drivers/pci/Makefile.
As explained in the section "Multiple Rules for One Target" of GNU make
documentation, other rules (i.e. in .depend) don't cancel this dependency.

Further, devlist.h depends on gen-devlist, so whenever drivers/pci/names.o
is to be compiled, devlist.h will be created before that.

> > This is caused by the patch for scripts/mkdep.c (part of the
> > 2.4.21-pre4-ac7 patch)
>
> Nope. It's the same with 2.4 from Marcelo.

Not true. 2.4.20 is fine:

make distclean
cp ~/local/linux/.config .
make oldconfig
make dep
make bzImage

No problems whatsoever.

-- 
Regards,
Pavel Roskin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:20 EST