Re: serial_cs with devfs

From: Zwane Mwaikambo (zwane@linuxpower.ca)
Date: Thu Feb 27 2003 - 02:42:51 EST


On Thu, 27 Feb 2003, _N3X_ wrote:

> in serial_cs.c there is a hardcoded device name in the code, stating
> ttySx, that's not the right thing with devfs..
> here's a patch of my own (should work also on the latest prepatch),
> just to show the problem, i think that the defines around it could be
> more carefully chosen, but what's the deal.. have a nice day.
> _N3X_ <n3x@coders.eu.org>
>
> diff -ru linux-2.4.19/drivers/char/pcmcia/serial_cs.c linux-2.4.19-fix/drivers/char/pcmcia/serial_cs.c
> --- linux-2.4.19/drivers/char/pcmcia/serial_cs.c 2001-12-21 18:41:54.000000000 +0100
> +++ linux-2.4.19-fix/drivers/char/pcmcia/serial_cs.c 2002-11-06 10:14:07.000000000 +0100
> @@ -256,7 +256,11 @@
> }
>
> info->line[info->ndev] = line;
> +#ifdef CONFIG_DEVFS_FS
> + sprintf(info->node[info->ndev].dev_name, "tts/%d", line);
> +#else
> sprintf(info->node[info->ndev].dev_name, "ttyS%d", line);
> +#endif /* CONFIG_DEVFS_FS */
> info->node[info->ndev].major = TTY_MAJOR;
> info->node[info->ndev].minor = 0x40+line;
> if (info->ndev > 0)

*cough* All that patch does is accentuate is one thing...

        Zwane

-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:40 EST