Hi!
> > This allows user to specify voltage manually. This gives me 40 extra
> > minutes (1h50m -> 2h30m) on HP omnibook which appears to have broken
> > bios tables. Please apply,
>
> Please don't apply this patch -- for the following reasons:
> - it only uses the deprecated, overloaded cpufreq proc_intf
> - selecting the voltage within the policy (minimum and maximum frequency,
> mode of operation) is not where it should be done: you may want a
> different voltage at min-speed as at max-speed. So the frequency tables,
> or -even better- the amd-k7-specific table may be a better choice for
> this.
Well, look again; if you use mVforce, it forces *just one* frequency
(min=max=freq you specified), so it is actually okay.
But I agree that hacking proc_intf is not the right thing to do. I did
not see that sysfs access. Where is it?
> - selecting the voltage manually is something which is only valid for some
> very few drivers - so let's only export one sysfs file[*] for these
> drivers.
Very few drivers? It should be common for at least Intel and AMD, no?
Pavel
-- Horseback riding is like software... ...vgf orggre jura vgf serr. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:30 EST