Re: check cpu_online() in nr_running()

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Tue Feb 25 2003 - 13:32:43 EST


On Tue, 2003-02-25 at 16:33, William Lee Irwin III wrote:
> for (i = 0; i < NR_CPUS; i++)
> + if (!cpu_online(i))
> + continue;
> sum += cpu_rq(i)->nr_running;

I smell donkey poo 8)

If the change is right, which seems reasonable then I think you
need some { } 's too. Its also a hot path so it may be a lot
cleaner to keep the jump out of this by just letting
nr_running be zero for other processors ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 28 2003 - 22:00:29 EST