Re: Longstanding networking / SMP issue? (duplextest)

From: David S. Miller (davem@redhat.com)
Date: Sun Feb 23 2003 - 04:58:19 EST


   From: Christoph Hellwig <hch@infradead.org>
   Date: Sun, 23 Feb 2003 10:02:34 +0000

> + icmp_xmit_lock();
   
   Hmm, and I guess the code would be much more readable if you used
   the spin_lock call directly. The impliclit icmp_socket doesn't
   really help readability either.
   
Sure it does, it encapsulates the icmp_socket->sk->foo->far->fum
dereferencing into one place instead of 4.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:38 EST