On Thu, Feb 20, 2003 at 07:06:13PM +0000, Christoph Hellwig wrote:
> > extern void (*br_fdb_put_hook)(struct net_bridge_fdb_entry *ent);
> > +static spinlock_t lec_arp_spinlock = SPIN_LOCK_UNLOCKED;
> > +static unsigned long lec_arp_flags;
> >
> > +#define LEC_ARP_LOCK() spin_lock_irqsave(&lec_arp_spinlock, lec_arp_flags);
> > +#define LEC_ARP_UNLOCK() spin_unlock_irqrestore(&lec_arp_spinlock, lec_arp_flags);
>
> I don't think this is a good idea - use the spin_lock calls directly and
> always use flags on the stack.
Good spotting, though I would be more direct :)
Simon sez, "Don't do that"
1) use 'unsigned long flags' on the stack
2) do _not_ pass this variable between functions
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:30 EST