Strange comment in sched.c

From: Michael Hayes (mike@aiinc.ca)
Date: Thu Feb 20 2003 - 14:20:18 EST


This comment at sched.c:843 is a bit confusing:

 * We fend off statistical fluctuations in runqueue lengths by
 * saving the runqueue length during the previous load-balancing
 * operation and using the smaller one the current and saved lengths.

First, it's ungrammatical ("...the smaller one the..."). Second,
the code immediately following it seems to be choosing the _larger_
of the two values, not the smaller:

if (idle || (this_rq->nr_running > this_rq->prev_nr_running[this_cpu]))
        nr_running = this_rq->nr_running;
else
        nr_running = this_rq->prev_nr_running[this_cpu];

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:30 EST