Hi!
> > --- clean/drivers/char/keyboard.c 2003-02-15 18:51:18.000000000 +0100
> > +++ linux/drivers/char/keyboard.c 2003-02-15 19:19:45.000000000 +0100
> > @@ -1020,6 +1041,23 @@
> > struct tty_struct *tty;
> > int shift_final;
> >
> > + /*
> > + * Fix for Toshiba Satellites. Toshiba's like to repeat
> > + * "key down" event for A in combinations like shift-A.
> > + * Thanx to Andrei Pitis <pink@roedu.net>.
> > + */
> > + static int prev_scancode = 0;
> > + static int stop_jiffies = 0;
> > +
> > + /* new scancode, trigger delay */
> > + if (keycode != prev_scancode) stop_jiffies = jiffies;
> > + else if (jiffies - stop_jiffies >= 10) stop_jiffies = 0;
> > + else {
> > + printk( "Keyboard glitch detected, ignoring keypress\n" );
> > + return;
> > + }
> > + prev_scancode = keycode;
> > +
> > if (down != 2)
> > add_keyboard_randomness((keycode << 1) ^ down);
>
> This is incredibly broken, on many layers.
>
> First, formatting does not respect the original code. Pavel, please,
> I do not care what crap you write in softsuspend, but this is a
> generic piece of code. Be kind to those who come next.
Its not originally mine, I should have reformated it. Sorry.
> Second, no HZ or other way to specify a wall clock interval.
> What if I run with HZ=4000? How do you protect against a
> jiffies wraparound?
>
> Third, I do not see how this is supposed to work at all.
> What if I hit two letters like in a word "Fool"? The up event
> is filtered already by this time, so, won't this code eat
> the second 'o'?
The up event is not filtered, AFAICS. Parameter down carries that.
Pavel
-- Casualities in World Trade Center: ~3k dead inside the building, cryptography in U.S.A. and free speech in Czech Republic. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:23 EST