Re: [patch] elv_former_request reversion

• Next message: Con Kolivas: "[BENCHMARK] 2.5.61-mm1 +/- as or cfq with contest"
• Previous message: Andrew Morton: "Re: tbench as a load - DDOS attack?"
• Next in thread: Jens Axboe: "Re: [patch] elv_former_request reversion"
• Reply: Jens Axboe: "Re: [patch] elv_former_request reversion"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Feb 15 2003, Andrew Morton wrote:
>
> This morning's fix for elv_former_request() is causing oopses all over the
> place in the IO scheduler.
>
> Jens, remember that I did try that fix a while ago, and the same happened.
>
> I believe it has exposed a new problem at the
> __make_request/attempt_front_merge level: if attempt_front_merge()
> actually succeeds, the wrong request gets freed up in
> elv_merged_request().
>
> It may be best to back this change out until it can be fixed up for
> real.

Yes agreed, I had forgotten about that point... Will fix.

-- 
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Con Kolivas: "[BENCHMARK] 2.5.61-mm1 +/- as or cfq with contest"
• Previous message: Andrew Morton: "Re: tbench as a load - DDOS attack?"
• Next in thread: Jens Axboe: "Re: [patch] elv_former_request reversion"
• Reply: Jens Axboe: "Re: [patch] elv_former_request reversion"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Feb 23 2003 - 22:00:14 EST