Race in RPC code

• Next message: Martin Zielinski: "TCP Connection times out"
• Previous message: Alan Cox: "Re: skb_padto and small fragmented transmits"
• In reply to: Jakob Oestergaard: "Race in RPC code"
• Next in thread: Jakob Oestergaard: "Re: Race in RPC code"
• Reply: Jakob Oestergaard: "Re: Race in RPC code"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

>>>>> " " == Jakob Oestergaard <jakob@unthought.net> writes:

> We don't know whether req has been modified between the
> assignment and the spin_lock.

It had better not be. If it is, then I want to know where so that we
can fix it.

req->rq_xprt is set up when the request is initialized. It
is not meant to change until the request gets released. This again
should not happen while the request is still on the wait queue.

IOW the fix you propose would just be papering over another problem.

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Martin Zielinski: "TCP Connection times out"
• Previous message: Alan Cox: "Re: skb_padto and small fragmented transmits"
• In reply to: Jakob Oestergaard: "Race in RPC code"
• Next in thread: Jakob Oestergaard: "Re: Race in RPC code"
• Reply: Jakob Oestergaard: "Re: Race in RPC code"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Feb 07 2003 - 22:00:23 EST