Re: [PATCH 2.5] fix megaraid driver compile error

From: Mark Haverkamp (markh@osdl.org)
Date: Thu Feb 06 2003 - 15:39:22 EST


On Thu, 2003-02-06 at 12:04, Linus Torvalds wrote:
> On 6 Feb 2003, Mark Haverkamp wrote:
> >
> > This moves access of the host element to device since host has been
> > removed from struct scsi_cmnd.
>
> This is whitespace-damaged.
>
> Please fix broken mailers. I generally don't bother to fix up whitespace
> damage from people who can't bother to have a good mailer. It's just not
> worth it - if I try to fix it up (even if it is often trivial), it just
> means that people will continue to send crap patches to me.
>
> Linus

Sorry about the bad patch. Is an attached text file OK?

-- 
Mark Haverkamp <markh@osdl.org>

===== drivers/scsi/megaraid.c 1.32 vs edited ===== --- 1.32/drivers/scsi/megaraid.c Fri Jan 3 10:58:49 2003 +++ edited/drivers/scsi/megaraid.c Thu Feb 6 10:18:43 2003 @@ -4515,7 +4515,7 @@ if(scsicmd == NULL) return -ENOMEM; memset(scsicmd, 0, sizeof(Scsi_Cmnd)); - scsicmd->host = shpnt; + scsicmd->device->host = shpnt; if( outlen || inlen ) { #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0) @@ -4652,7 +4652,7 @@ if(scsicmd == NULL) return -ENOMEM; memset(scsicmd, 0, sizeof(Scsi_Cmnd)); - scsicmd->host = shpnt; + scsicmd->device->host = shpnt; if (outlen || inlen) { #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 07 2003 - 22:00:21 EST