RE: [PATCH][RFC] Discontigmem support for the x440

From: Grover, Andrew (andrew.grover@intel.com)
Date: Thu Feb 06 2003 - 15:16:34 EST


> From: Patricia Gaughen [mailto:gone@us.ibm.com]
> This patch provides discontigmem support for the IBM x440.
> This code has
> passed through the hands of several developers: Chandra
> Seetharaman, James
> Cleverdon, John Stultz, and last to touch it, me :-) This
> patch requires full
> acpi support.
>
> I've tested this patch on an 8 way x440 16 GB of RAM with and
> without HT
> (acpi=off).
>
> Any and all feedback regarding this patch is greatly appreciated.
> --- a/drivers/acpi/events/evevent.c Wed Feb 5 19:15:58 2003
> +++ b/drivers/acpi/events/evevent.c Wed Feb 5 19:15:58 2003
> @@ -104,6 +104,7 @@
>
> ACPI_FUNCTION_TRACE ("ev_handler_initialize");
>
> + return_ACPI_STATUS (0);
>
> /* Install the SCI handler */
>

This part breaks ACPI event handling.

I'm guessing you just stuck that in there to get things working, but we
all need to figure out more of why this is an issue, and fix things
properly.

Other than that, thumbs up. SRAT support is a good thing to have.

Regards -- Andy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 07 2003 - 22:00:21 EST