Re: [PATCH] PCI Hotplug changes for 2.5.59

From: Greg KH (greg@kroah.com)
Date: Wed Feb 05 2003 - 23:08:05 EST


ChangeSet 1.947.23.12, 2003/02/06 10:14:04+11:00, randy.dunlap@verizon.net

[PATCH] PCI Hotplug: memory leaks in acpiphp_glue

Here's the memory leaks patch for acpiphp_glue.c.

diff -Nru a/drivers/hotplug/acpiphp_glue.c b/drivers/hotplug/acpiphp_glue.c
--- a/drivers/hotplug/acpiphp_glue.c Thu Feb 6 14:51:22 2003
+++ b/drivers/hotplug/acpiphp_glue.c Thu Feb 6 14:51:22 2003
@@ -578,6 +578,7 @@
                 bridge->io_head = acpiphp_make_resource((u64)base, limit - base + 1);
                 if (!bridge->io_head) {
                         err("out of memory\n");
+ kfree(bridge);
                         return;
                 }
                 dbg("16bit I/O range: %04x-%04x\n",
@@ -592,6 +593,7 @@
                 bridge->io_head = acpiphp_make_resource((u64)base, limit - base + 1);
                 if (!bridge->io_head) {
                         err("out of memory\n");
+ kfree(bridge);
                         return;
                 }
                 dbg("32bit I/O range: %08x-%08x\n",
@@ -613,6 +615,7 @@
         bridge->mem_head = acpiphp_make_resource((u64)base, limit - base + 1);
         if (!bridge->mem_head) {
                 err("out of memory\n");
+ kfree(bridge);
                 return;
         }
         dbg("32bit Memory range: %08x-%08x\n",
@@ -632,6 +635,7 @@
                 bridge->p_mem_head = acpiphp_make_resource((u64)base, limit - base + 1);
                 if (!bridge->p_mem_head) {
                         err("out of memory\n");
+ kfree(bridge);
                         return;
                 }
                 dbg("32bit Prefetchable memory range: %08x-%08x\n",
@@ -647,6 +651,7 @@
                 bridge->p_mem_head = acpiphp_make_resource(base64, limit64 - base64 + 1);
                 if (!bridge->p_mem_head) {
                         err("out of memory\n");
+ kfree(bridge);
                         return;
                 }
                 dbg("64bit Prefetchable memory range: %08x%08x-%08x%08x\n",

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 07 2003 - 22:00:19 EST