Re: [PATCHes available] printk() without KERN_ prefixes? (in 2.5.59) (again)

From: Ph. Marek (philipp.marek@bmlv.gv.at)
Date: Tue Feb 04 2003 - 05:58:20 EST


> > #ifdef LITTLE_ENDIAN
> > (wptr[(((win + 1)*4)^4)/4] != 0)) {
> > #else
> > (wptr[win + 1] != 0)) {
> > #endif /* LITTLE_ENDIAN */
> > (the braces { and } don't add up in the file).
>
> they do, but your script doesn't use c preprocessor with right flags,
> which it probably should.
>
> The two braces above should be counted as one depending on LITTLE_ENDIAN
> defined.
# wc change_printk.pl
    141 268 2361 change_printk.pl
I don't use the preprocessor - after all, which -D should I give? all? none? a
part? So my script just reads the files.

I know that my script could parse the #if's also - but that's a lot of work
with little use.

How about that?

        #if defined(FORCE_ERRORS)
                if (0) {
        #elif !DEBUG
                if (kdebug) {
        #endif
        ...
        #if !DEBUG || defined(FORCE_ERRORS)
                }
        #endif
(seen in arch/ia64/sn/io/sn2/pcibr/pcibr_error.c: pcibr_pioerror() )

It's just too complex to look on the #if's and gives not enough advantages.

Regards,

Phil

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 07 2003 - 22:00:14 EST