Re: two x86_64 fixes for 2.4.21-pre3

From: Ton Hospel (linux-kernel@ton.iguana.be)
Date: Mon Feb 03 2003 - 22:13:22 EST


In article <15921.37163.139583.74988@harpo.it.uu.se>,
        Mikael Pettersson <mikpe@csd.uu.se> writes:
> #define safe_halt() __asm__ __volatile__("sti; hlt": : :"memory")
>
> +#define __save_and_cli(x) do { __save_flags(x); __cli(); } while(0);
> +#define __save_and_sti(x) do { __save_flags(x); __sti(); } while(0);
> +

The extra ; after the while(0) look wrong.

> #define restore_flags(x) __global_restore_flags(x)
> +#define save_and_cli(x) do { save_flags(x); cli(); } while(0);
> +#define save_and_sti(x) do { save_flags(x); sti(); } while(0);

Same here
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 07 2003 - 22:00:13 EST