Re: Patch?: linux-2.5.59/sound/soundcore.c referenced non-existant errno variable

From: Horst von Brand (brand@jupiter.cs.uni-dortmund.de)
Date: Tue Jan 21 2003 - 12:01:20 EST


Bill Davidsen <davidsen@tmr.com> said:

[...]

> I have not looked at the code this generates, it's a comment on human
> readability rather than an actual implementation, and I'm sure someone
> will argue that the first failure should just be a return if there's
> nothing else which needs to be done. On the other hand the return inline
> would be more bytes, so someone else can argue against.

Older gccs used to generate horrible code for several "return foo;" in the
function, dunno how it is today.

Besides, today there might be nothing else to do, but that can change. In
that case you'd better have all exits together.

-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:27 EST