Re: [PATCH][2.5] smp_call_function_mask

From: Alan (alan@lxorguk.ukuu.org.uk)
Date: Mon Jan 20 2003 - 18:19:05 EST

On Fri, 2003-01-17 at 05:18, Zwane Mwaikambo wrote:
> + /* Wait for response */
> + while (atomic_read(&data.started) != num_cpus)
> + barrier();

Only old old intel x86 that does -bad- things as it
generates a lot of bus locked cycles. Better to do

        while(atomic_read(&data.started) != num_cpus)
                while(data.started.value != num_cpus)
                {
                        barrier();
                        cpu_relax();
                }

I would think ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:25 EST