Re: 2.4.21pre3 smp_affinity, very strange

From: Hans Lambrechts (hans.lambrechts@skynet.be)
Date: Mon Jan 20 2003 - 11:41:02 EST


Thanks Manfred and Arjan for responding, and for the solution :-)

My box works now as before.

pc:~ # cat /proc/interrupts
           CPU0 CPU1
  0: 5894 5418 IO-APIC-edge timer
  1: 57 40 IO-APIC-edge keyboard
  2: 0 0 XT-PIC cascade
  8: 0 2 IO-APIC-edge rtc
  9: 0 0 IO-APIC-edge acpi
 12: 283 223 IO-APIC-edge PS/2 Mouse
 14: 4 3 IO-APIC-edge ide0
 16: 4044 3976 IO-APIC-level aic7xxx
 18: 50 42 IO-APIC-level eth0
NMI: 11227 11227
LOC: 11204 11203
ERR: 0
MIS: 0

Patch attached at the bottom of the page. If any comments, please cc me.
 
On Sunday 19 January 2003 19:54, you wrote:
> > Did the APIC or mpparse changes cause this?
>
> +#ifdef CONFIG_X86_CLUSTERED_APIC
> +static inline int target_cpus(void)
> +{
> + static int cpu;
> + switch(clustered_apic_mode){
> + case CLUSTERED_APIC_NUMAQ:
> + /* Broadcast intrs to local quad only. */
> + return APIC_BROADCAST_ID_APIC;
> + case CLUSTERED_APIC_XAPIC:
> + /*round robin the interrupts*/
> + cpu = (cpu+1)%smp_num_cpus;
> + return cpu_to_physical_apicid(cpu);
> + default:
> + }
> + return cpu_online_map;
> +}
> +#else
> +#define target_cpus() (0x01)
> +#endif
> (2.4.21-pre3)
> that's wrong..... 0x01 -> 0xFF and it should be fixed

--- linux/include/asm-i386/smpboot.h 2003-01-20 16:45:13.000000000 +0100
+++ linux/include/asm-i386/smpboot.h.orig 2003-01-20 16:44:05.000000000 +0100
@@ -116,6 +116,6 @@
        return cpu_online_map;
 }
 #else
-#define target_cpus() (0xFFFFFFFF)
+#define target_cpus() (0x01)
 #endif
 #endif

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:23 EST