Re: recent change to exit_mmap

From: Anton Blanchard (anton@samba.org)
Date: Sat Jan 18 2003 - 02:23:31 EST


> On seconds thoughts...
>
> Are the first two SET_PERSONALITY() calls in there actually doing anything?
> Perhaps you're right, and we only need the one at line 615, whcih is in the
> right place?

Sounds good. The following patch tests out OK.

Anton

===== fs/binfmt_elf.c 1.34 vs edited =====
--- 1.34/fs/binfmt_elf.c Mon Nov 25 19:59:02 2002
+++ edited/fs/binfmt_elf.c Sat Jan 18 18:16:52 2003
@@ -536,8 +536,6 @@
                             strcmp(elf_interpreter,"/usr/lib/ld.so.1") == 0)
                                 ibcs2_interpreter = 1;
 
- SET_PERSONALITY(elf_ex, ibcs2_interpreter);
-
                         interpreter = open_exec(elf_interpreter);
                         retval = PTR_ERR(interpreter);
                         if (IS_ERR(interpreter))
@@ -578,9 +576,6 @@
                         // printk(KERN_WARNING "ELF: Ambiguous type, using ELF\n");
                         interpreter_type = INTERPRETER_ELF;
                 }
- } else {
- /* Executables without an interpreter also need a personality */
- SET_PERSONALITY(elf_ex, ibcs2_interpreter);
         }
 
         /* OK, we are done with that, now set up the arg stuff,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jan 23 2003 - 22:00:17 EST