Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Fri Jan 10 2003 - 05:20:31 EST

Next message: Rusty Russell: "Re: Another idea for simplifying locking in kernel/module.c"
Previous message: John Bradford: "Re: Problem in IDE Disks cache handling in kernel 2.4.XX"
In reply to: Richard Henderson: "Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty"
Next in thread: Linus Torvalds: "Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty"
Reply: Linus Torvalds: "Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <20030110015203.A16268@twiddle.net> you write:
> On Wed, Jan 08, 2003 at 10:56:51PM +1100, Rusty Russell wrote:
> > + char sym_name[strlen(obsparm[i].name) + 2];
>
> Are you really intending to use variable sized allocation
> on the kernel stack?

Yep. Maximum length of obsolete parameter name in current kernel:
seq_default_timer_resolution (28 chars).

It's far more likely that someone will hit the unchecked kmalloc
allocations in arch/alpha/kernel/modules.c 8)

Hope that helps,
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Rusty Russell: "Re: Another idea for simplifying locking in kernel/module.c"
Previous message: John Bradford: "Re: Problem in IDE Disks cache handling in kernel 2.4.XX"
In reply to: Richard Henderson: "Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty"
Next in thread: Linus Torvalds: "Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty"
Reply: Linus Torvalds: "Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PREFIX is non-empty"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Jan 15 2003 - 22:00:32 EST