Re: [SERIAL] change_speed -> settermios change

From: David S. Miller (davem@redhat.com)
Date: Mon Jan 06 2003 - 02:02:18 EST


   From: Russell King <rmk@arm.linux.org.uk>
   Date: Fri, 3 Jan 2003 16:19:16 +0000
   
   I have one concerns surrounding the three drivers mentioned above.
   Currently, they blindly use uart_get_baud_rate() without limiting the
   maximum baud rate. Since the baud rate will be limited (by the
   hardware), we must limit the resulting baud rate must be reflected
   back into the termios c_cflag member.

Hmmm, maybe it's a better idea to store the min/max in the UART port
structure and have the upper layer do the limiting before we call
down into the driver?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jan 07 2003 - 22:00:31 EST