Re: [RFC] irq handling code consolidation, second try (v850 part)

From: Miles Bader (miles@gnu.org)
Date: Sat Jan 04 2003 - 08:00:29 EST

Next message: Benjamin Herrenschmidt: "Re: [RFC] irq handling code consolidation, second try (ppc part)"
Previous message: Kasper Dupont: "Re: Linux v2.5.54"
Maybe in reply to: Andrey Panin: "[RFC] irq handling code consolidation, second try (v850 part)"
Next in thread: Andrey Panin: "Re: [RFC] irq handling code consolidation, second try (v850 part)"
Reply: Andrey Panin: "Re: [RFC] irq handling code consolidation, second try (v850 part)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Can't test it, but the v850 part looks great, ah, it's lovely to see all
that code being deleted...

One comment: `arch_check_irq' is a bad name, it doesn't make it at all
clear what it does.

I might suggest inverting the sense, and using `irq_valid' -- the `arch_'
prefix seems unnecessary (as with `irq_desc') since it's not a
arch-specific version of a more general wrapper.

Thanks,

-Miles

-- 
Quidquid latine dictum sit, altum viditur.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Benjamin Herrenschmidt: "Re: [RFC] irq handling code consolidation, second try (ppc part)"
Previous message: Kasper Dupont: "Re: Linux v2.5.54"
Maybe in reply to: Andrey Panin: "[RFC] irq handling code consolidation, second try (v850 part)"
Next in thread: Andrey Panin: "Re: [RFC] irq handling code consolidation, second try (v850 part)"
Reply: Andrey Panin: "Re: [RFC] irq handling code consolidation, second try (v850 part)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Jan 07 2003 - 22:00:25 EST