GET_TIMEOUT too small for hotplugging in usb.c (2.4.20)

From: A E Lawrence (A.E.Lawrence@lboro.ac.uk)
Date: Fri Jan 03 2003 - 17:46:44 EST


There seem to be several threads in the archives which report problems that
the small timeout seems to explain. Details attached.

ael

GET_TIMEOUT in usb.c requires a larger value to permit hotplugging
------------------------------------------------------------------

drivers/usb/usb.c from 2.4.20 (no version number in file)

#ifdef CONFIG_USB_LONG_TIMEOUT
#define GET_TIMEOUT 20 <== This was 4
#else
#define GET_TIMEOUT 3
#endif
#define SET_TIMEOUT 3

Hotplugging my usb Epson scanner ceased to work sometime ago. I have just
traced this to a short GET_TIMEOUT in usb.c as above.

It is well known that Epson scanners take a long time to respond.
Mine takes around 12 seconds: the explanation seems to be that it switchs
on the transparency light source and waits for it to stabilize before answering
enquiries. This is covered in scanner.c which uses extended timeouts for
Epsons.

However, even with CONFIG_USB_LONG_TIMEOUT set, the timeout in usbcore is only
4 seconds, so the hotplug script does not get called to load that scanner
module. So the longer value of GET_TIMEOUT needs to be increased to at least
15 seconds, perhaps much longer to cover other devices that may be even slower?
Or should it become a module parameter?

A.E.Lawrence

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jan 07 2003 - 22:00:23 EST