Re: [PATCH 2.5.54] hermes: serialization fixes

From: Benjamin LaHaise (bcrl@redhat.com)
Date: Fri Jan 03 2003 - 12:47:54 EST


On Fri, Jan 03, 2003 at 12:39:29PM -0500, Stephen Evanchik wrote:
> The hermes MAC controller module wasn't serializing BAP seek calls. This
> caused an eventual Rx/Tx failure which equates tens of thousands of errors on
> the wireless interface. A simple spinlock is used to keep things in line.
>
> Any comments are appreciated, I don't believe this is the best solution, but
> it is working well. Patches can be downloaded from here:

Why not put the spinlock/unlock inside hermes_bap_seek()? Smaller, better
contained and more readable.

                -ben
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jan 07 2003 - 22:00:21 EST