The kernel symbol stem compression patch included in 2.5.54 unfortunately
had a few problems, triggered by various circumstances.
On some gas \x... in string constants seems to randomly eat any following
hex like character.
Hardens it more against bogus symbol table entries.
This should fix the reported crashes. No need anymore for akpm to
back it out.
Please apply.
-Andi
--- linux-vanilla/kernel/kallsyms.c 2003-01-02 06:55:55.000000000 +0100
+++ linux/kernel/kallsyms.c 2003-01-02 11:06:30.000000000 +0100
@@ -32,6 +32,7 @@
BUG();
namebuf[127] = 0;
+ namebuf[0] = 0;
if (addr >= (unsigned long)_stext && addr <= (unsigned long)_etext) {
unsigned long symbol_end;
@@ -46,9 +47,9 @@
/* Grab name */
for (i = 0; i < best; i++) {
- ++name;
- strncpy(namebuf + name[-1], name, 127);
- name += strlen(name)+1;
+ unsigned prefix = *name++;
+ strncpy(namebuf + prefix, name, 127);
+ name += strlen(name) + 1;
}
/* Base symbol size on next symbol. */
--- linux-vanilla/scripts/kallsyms.c 2003-01-02 06:55:56.000000000 +0100
+++ linux/scripts/kallsyms.c 2003-01-02 11:02:18.000000000 +0100
@@ -144,7 +144,7 @@
for (k = 0; table[i].sym[k] && table[i].sym[k] == prev[k]; ++k)
;
- printf("\t.asciz\t\"\\x%02x%s\"\n", k, table[i].sym + k);
+ printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n", k, table[i].sym + k);
last_addr = table[i].addr;
prev = table[i].sym;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jan 07 2003 - 22:00:17 EST