Re: [PATCH] generic device DMA (dma_pool update)

From: David Brownell (david-b@pacbell.net)
Date: Wed Jan 01 2003 - 21:11:43 EST


James Bottomley wrote:
> adam@yggdrasil.com said:
>
>> Can someone show me or invent an example of two different uses of
>>dma_alloc_coherent that really should use different policies on
>>whether to block or not?
>
>
> The obvious one is allocations from interrupt routines, which must be
> GFP_ATOMIC (ignoring the issue of whether a driver should be doing a memory
> allocation in an interrupt). Allocating large pools at driver initialisation
> should probably be GFP_KERNEL as you say.

More: not just "from interrupt routines", also "when a spinlock is held".
Though one expects that if a dma_pool were in use, it'd probably have one
of that kind of chunk already available (ideally, even initialized).

Many task-initiated allocations would use GFP_KERNEL; not just major driver
activation points like open().

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jan 07 2003 - 22:00:16 EST