On Wed, Jan 01, 2003 at 03:43:05PM -0800, Linus Torvalds wrote:
>
> On Thu, 2 Jan 2003, Christoph Hellwig wrote:
> >
> > To avoid ifdef hell I extented the task_foo() abstraction already
> > present in array.c a bit and the actual implementations now live
> > in task_mmu.c and task_nommu.c.
>
> Please do "proc_mmu.c" and "proc_nommu.c", and move the non-task-related
> parts there too (ie move "pid_maps_read()" there too, and just make the
> no-mmu version of it be empty or whatever, ok?)
I can add an empty stub function, but that doesn't help to reduce the
ifdef mess as there is no /proc/<pid>/maps on nommu at all so we don't
have the struct file_operations and more important can't register it.
Maybe I need to make adding new entries for /proc/<pid>/ dynamic so
proc_mmu.c can just call
create_proc_pid_entry("stats", &proc_maps_operations, ...)
> > --- 1.4/fs/proc/Makefile Sat Dec 14 07:38:56 2002
> > +++ edited/fs/proc/Makefile Wed Jan 1 13:45:28 2003
> > @@ -9,6 +9,12 @@
> > proc-objs := inode.o root.o base.o generic.o array.o \
> > kmsg.o proc_tty.o proc_misc.o kcore.o
> >
> > +ifeq ($(CONFIG_MMU),y)
> > +proc-objs += task_mmu.o
> > +else
> > +proc-objs += task_nommu.o
> > +endif
>
> Isn't it much nicer to just write this something like
>
> proc-mmu-y = proc_mmu.o
> proc-mmu-n = proc_nommu.o
>
> obj-y += $(proc-mmu-$(CONFIG_MMU))
>
> instead, and avoid conditionals?
Could be done. Maybe Kai even has an even nicer generic version? :)
The new makefiles really need some docs..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jan 07 2003 - 22:00:16 EST