[PATCH] printks in drivers/scsi/hosts.c missing return

From: Robert Love (rml@tech9.net)
Date: Fri Dec 13 2002 - 21:23:05 EST


Trivial but annoying: two printk() calls in drivers/scsi/hosts.c are
missing '\n'

Also, for some reason I have not yet investigated, shost_tp->name is
NULL here. This should not be, eh? If it can be, we should do
something to tidy up the printing of it.

Patch is against 2.5.51. Linus, please apply.

        Robert Love

 drivers/scsi/hosts.c | 4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -urN linux-2.5.51-mm1/drivers/scsi/hosts.c linux/drivers/scsi/hosts.c
--- linux-2.5.51-mm1/drivers/scsi/hosts.c 2002-12-10 17:45:02.000000000 -0500
+++ linux/drivers/scsi/hosts.c 2002-12-11 00:40:28.000000000 -0500
@@ -488,14 +488,14 @@
         if (!shost_tp->max_sectors) {
                 printk(KERN_WARNING
                     "scsi HBA driver %s didn't set max_sectors, "
- "please fix the template", shost_tp->name);
+ "please fix the template\n", shost_tp->name);
                 shost_tp->max_sectors = 1024;
         }
 
         if (!shost_tp->release) {
                 printk(KERN_WARNING
                     "scsi HBA driver %s didn't set a release method, "
- "please fix the template", shost_tp->name);
+ "please fix the template\n", shost_tp->name);
                 shost_tp->release = &scsi_host_legacy_release;
         }
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Dec 15 2002 - 22:00:30 EST