Re: dmfs for 2.5.51

From: Greg KH (
Date: Fri Dec 13 2002 - 12:29:56 EST

On Fri, Dec 13, 2002 at 09:37:45AM +0000, Joe Thornber wrote:
> Greg,
> On Thu, Dec 12, 2002 at 05:26:19PM -0800, Greg KH wrote:
> > Here's a patch against 2.5.51 with a updated dmfs.
> I've split out your two changes into seperate patches (patches 21 and
> 22) and made them available here:


> > with the following modifications:
> > - fixed compile time warnings with the dbg() macro (something
> > better should be used here, I just commented it out...)
> I'm not seeing any warnings, which compiler version are you using ?

The latest for Red Hat 7.2: gcc-2.96-112.7.2
Are you using 3.2?

> > - changed the dev file to print out the kdev value, not be the
> > actual block device.
> Should we really be exporting a kdev_t to userland, why not just print out
> <major>:<minor>

No, look at the other dev files in sysfs, I stayed consistant with them.

> > With regards to the last change, I didn't follow the way the other files
> > operate with their complex page creation structure, as this is only a
> > simple one line file. If the lvm developers want me to change this, I
> > will.
> What you've done looks fine to me, though allocating a whole page to
> hold a single number seems overkill. Why don't you just snprintf into
> a char[] held on the stack ?

Because I forgot you could do copy_to_user() with data on the stack :)
Good point, I'll change it...

> > If not, I would argue that a number of the other files created
> > should be changed to use this simpler format. Or is there some reason
> > for creating these lists of pages that I'm missing?
> The files can be larger than a single page, which complicates things
> somewhat.

Hm, then using the seq_file interface might be easier. I'll look into


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sun Dec 15 2002 - 22:00:29 EST