Re: [PATCH][2.5][CFT] ad1848 PnP updates + fixes

From: Zwane Mwaikambo (zwane@holomorphy.com)
Date: Fri Dec 13 2002 - 06:15:11 EST

Next message: Daniel Egger: "Re: Why does C3 CPU downgrade in kernel 2.4.20?"
Previous message: Eyal Lebedinsky: "Re: [PATCH] 2.4.20-rmap15b - compile failure"
In reply to: Zwane Mwaikambo: "[PATCH][2.5][CFT] ad1848 PnP updates + fixes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Adam,
I had the following hunk from the previous patch to this file, do
we really want to disable that device here?

On Thu, 12 Dec 2002, Zwane Mwaikambo wrote:

> #ifdef CONFIG_PNP
> - if(ad1848_dev){
> - if(audio_activated)
> - pnp_disable_dev(ad1848_dev);
> - put_device(&ad1848_dev->dev);
> +{
> + ad1848_info *p;
> +
> + if (audio_activated == 0)
> + return;
> +
> + while (--nr_ad1848_devs >= 0) {
> + p = &adev_info[nr_ad1848_devs];
> + pnp_disable_dev(p->pnp_dev); /* XXX Should this be done here? */
> + put_device(&p->pnp_dev->dev);
> }
> + pnp_unregister_driver(&ad1848_driver);
> +}
> #endif

-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Daniel Egger: "Re: Why does C3 CPU downgrade in kernel 2.4.20?"
Previous message: Eyal Lebedinsky: "Re: [PATCH] 2.4.20-rmap15b - compile failure"
In reply to: Zwane Mwaikambo: "[PATCH][2.5][CFT] ad1848 PnP updates + fixes"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Dec 15 2002 - 22:00:28 EST