Re: [TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Wed Dec 11 2002 - 20:29:45 EST

Next message: Alan Cox: "Re: HyperThreading in recent 2.4-ac kernels"
Previous message: Davide Libenzi: "[patch/trvial^3] epoll bits forgot a nasty printk() ..."
In reply to: Bob Miller: "[TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 2002-12-11 at 22:28, Bob Miller wrote:
> The function, cs5520_tune_chipset() is declared to return an int.
> Added a return statement instead of just falling of off the bottom.
>
> diff -Nru a/drivers/ide/pci/cs5520.c b/drivers/ide/pci/cs5520.c
> --- a/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
> +++ b/drivers/ide/pci/cs5520.c Wed Dec 11 13:41:51 2002
> @@ -166,6 +166,8 @@
> /* ATAPI is harder so leave it for now */
> if(!error && drive->media == ide_disk)
> error = hwif->ide_dma_on(drive);
> +
> + return error;

Eep thats a nasty little bug, lucky my compiler left the error value in
%eax anyway good spotting

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Alan Cox: "Re: HyperThreading in recent 2.4-ac kernels"
Previous message: Davide Libenzi: "[patch/trvial^3] epoll bits forgot a nasty printk() ..."
In reply to: Bob Miller: "[TRIVIAL PATCH 2.5.51] Remove compile warning from drivers/ide/pci/cs5520.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Dec 15 2002 - 22:00:23 EST