Re: Problem with mm1 patch for 2.5.51

From: Andrew Morton (akpm@digeo.com)
Date: Wed Dec 11 2002 - 00:08:54 EST


Aniruddha M Marathe wrote:
>
> Hi,
> I applied mm1 patch to kernel 2.5.51 and I ran LM bench to test its performance.
> Here are the errors that I obtained.
>
> EXT3-fs error (device ide0(3,6)) in start_transaction: Journal has aborted

An off-by-one was gratuitously added to ext3_free_blocks

--- 25/fs/ext3/balloc.c~dud-patch Tue Dec 10 21:07:20 2002
+++ 25-akpm/fs/ext3/balloc.c Tue Dec 10 21:07:27 2002
@@ -122,7 +122,7 @@ void ext3_free_blocks (handle_t *handle,
         es = EXT3_SB(sb)->s_es;
         if (block < le32_to_cpu(es->s_first_data_block) ||
             block + count < block ||
- block + count >= le32_to_cpu(es->s_blocks_count)) {
+ block + count > le32_to_cpu(es->s_blocks_count)) {
                 ext3_error (sb, "ext3_free_blocks",
                             "Freeing blocks not in datazone - "
                             "block = %lu, count = %lu", block, count);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Dec 15 2002 - 22:00:20 EST