Hi,
Okay, I know, it's just a library module, doesn't need to ever be unloaded
anyway. But error noise in dmesg annoys me, hence this patch.
Matt
Convert CRC32 to try_module_get; fixes an unsafe usage that
prevents unloading.
lib/crc32.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletion(-)
--- linux-2.5.50/lib/crc32.c~crc32-unsafe 2002-11-30 05:31:19.000000000 -0600
+++ linux-2.5.50-arashi/lib/crc32.c 2002-11-30 05:36:17.000000000 -0600
@@ -551,7 +551,10 @@ static int __init init_crc32(void)
rc1 = crc32init_le();
rc2 = crc32init_be();
rc = rc1 || rc2;
- if (!rc) MOD_INC_USE_COUNT;
+ if (!rc) {
+ if (!try_module_get(THIS_MODULE))
+ rc = -1;
+ }
return rc;
}
[patch ends]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Nov 30 2002 - 22:00:25 EST