Re: [PATCH] C99 initializers for drivers/media/radio

• Next message: Jeff Garzik: "Re: [PATCH] C99 initializers for drivers/media/radio"
• Previous message: Ralf Baechle: "Re: [PATCH] Start of compat32.h (again)"
• In reply to: Art Haas: "[PATCH] C99 initializers for drivers/media/radio"
• Next in thread: Jeff Garzik: "Re: [PATCH] C99 initializers for drivers/media/radio"
• Reply: Jeff Garzik: "Re: [PATCH] C99 initializers for drivers/media/radio"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In article <20021130174509.GD10613@debian> you wrote:
> Here's a patch set for switching drivers/media/radio to use C99
> initializers. The patches are against 2.5.50.
...
> static struct pcm20_device pcm20_unit = {
> - freq: 87*16000,
> - muted: 1,
> - stereo: 0
> + .freq = 87*16000,
> + .muted = 1,
> };
...

IMHO it is not a good idea to skip default initilised members. IT is self
documenting to see all members, and it is easier to change them, if
required. Especially if the old code had it.

Greetings
Bernd

-- 
eckes privat - http://www.eckes.org/
Project Freefire - http://www.freefire.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Jeff Garzik: "Re: [PATCH] C99 initializers for drivers/media/radio"
• Previous message: Ralf Baechle: "Re: [PATCH] Start of compat32.h (again)"
• In reply to: Art Haas: "[PATCH] C99 initializers for drivers/media/radio"
• Next in thread: Jeff Garzik: "Re: [PATCH] C99 initializers for drivers/media/radio"
• Reply: Jeff Garzik: "Re: [PATCH] C99 initializers for drivers/media/radio"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Nov 30 2002 - 22:00:24 EST