Re: [PATCH][2.5] xircom_cb small cleanups

From: Jeff Garzik (jgarzik@pobox.com)
Date: Sat Nov 30 2002 - 14:35:18 EST


Patch looks basically ok, but you should get together with Dave Jones
and come up with a unified patch that also eliminates the
private=kmalloc allocation by filling in init_etherdev's 2nd argument.

Both init_etherdev and alloc_etherdev allocate struct net_device* and
dev->priv in a single allocation. As an additional bonus, dev->priv is
aligned on a 32-byte [not bit] boundary, and the entire area is zeroed
with memset()

        Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 30 2002 - 22:00:24 EST