Re: [PATCH 2.5] crc32 static initialization

From: Brian Murphy (brian@murphy.dk)
Date: Sat Nov 23 2002 - 12:52:04 EST


Joakim Tjernlund wrote:

>I have tested the new CRC32 patch on my big endian CPU(mpc860) in
>linux 2.4. Since the Makefiles look different in 2.4 vs. 2.5 I built and ran
>gen_crctable.c manually, so I can not comment on the Makefile changes.
>
>Also, testing this in 2.4 makes it hard to generate a new 2.5 patch, so
>I will just comment and send the whole file(se below)
>
>
Thanks for the testing.

>Found this:
>
> crc32.c in crc32_be(): crc32table_le should be crc32table_be
>
>
Can you send me a patch? I just used the original patch you sent me
which uses
crc32table_le in crc32_be.

>
> Finally, I think the new local crc32.h should be renamed to crc32defs.h to
> avoid confusion with the real linux/crc32.h.
>
>
Possibly, all h files contain "defs".

/Brian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:43 EST