Re: [RFC] [PATCH] subarch cleanup

From: J.E.J. Bottomley (James.Bottomley@HansenPartnership.com)
Date: Fri Nov 22 2002 - 10:00:47 EST


mbligh@aracnet.com said:
> > Why do you need to move the .h files?
> Because they're in a silly place now. They should be whereever all the
> other include files are.

> > CFLAGS += -Iarch/i386/$(MACHINE_H) -Iarch/i386/mach-generic
> > That should achieve the same effect?

> Header files go under include ....

That's not necessarily true. Externally useful header files go in include.
Header files only used internally to the subsystem go in local directories.

The reason I put them under arch/i386 is because I didn't want the guts of the
subarch splitup spilling into the kernel core.

While the subarch is local to i386, I think the headers should stay there. If
you want to make the subarch a global framework (and thus get agreement with
Russel and ARM to use it) then putting them under the global include
directories would probably make sense.

James

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:40 EST