Re: [PATCH] More missing includes [1/4]

From: Richard Henderson (rth@twiddle.net)
Date: Mon Nov 18 2002 - 19:19:47 EST


On Mon, Nov 18, 2002 at 11:17:45PM +0000, Russell King wrote:
> The more obvious solution is to remove the __initdata from the
> declaration on line 545. Such usage of __initdata (and __init)
> serves no purpose.

Yes it does. If the variable is small, then the compiler may
expect the variable to be placed in the .sdata section, and so
be reachable by, say, a 16-bit gp-relative relocation.

Now, this variable in particular may not be small enough for
that, but the fact remains that the general rule should be that
variables should be declared with their section attributes.

r~
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:25 EST