Hi Linus,
I'd like to recommend that you apply this to fix
fs/devfs/base.c compilation problems instead of Andi's patch, as this
one ensures that {a,m,c}time will all have the same value even if
successive calls to get_seconds() might someday be able to return
different values. Do you concur, Andi?
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
--- linux-2.5.48/fs/devfs/base.c 2002-11-17 20:29:26.000000000 -0800
+++ linux/fs/devfs/base.c 2002-11-18 16:04:13.000000000 -0800
@@ -3029,9 +3029,7 @@
de->vfs_deletable = TRUE;
de->inode.uid = current->euid;
de->inode.gid = current->egid;
- de->inode.atime = CURRENT_TIME;
- de->inode.mtime = CURRENT_TIME;
- de->inode.ctime = CURRENT_TIME;
+ de->inode.ctime = de->inode.mtime = de->inode.atime = get_seconds();
if ( ( inode = _devfs_get_vfs_inode (dir->i_sb, de, dentry) ) == NULL )
return -ENOMEM;
DPRINTK (DEBUG_DISABLED, "(%s): new VFS inode(%u): %p dentry: %p\n",
@@ -3060,9 +3058,7 @@
return err;
de->inode.uid = current->euid;
de->inode.gid = current->egid;
- de->inode.atime = CURRENT_TIME;
- de->inode.mtime = CURRENT_TIME;
- de->inode.ctime = CURRENT_TIME;
+ de->inode.ctime = de->inode.mtime = de->inode.atime = get_seconds();
if ( ( inode = _devfs_get_vfs_inode (dir->i_sb, de, dentry) ) == NULL )
return -ENOMEM;
DPRINTK (DEBUG_DISABLED, "(%s): new VFS inode(%u): %p dentry: %p\n",
@@ -3129,9 +3125,7 @@
return err;
de->inode.uid = current->euid;
de->inode.gid = current->egid;
- de->inode.atime = CURRENT_TIME;
- de->inode.mtime = CURRENT_TIME;
- de->inode.ctime = CURRENT_TIME;
+ de->inode.ctime = de->inode.mtime = de->inode.atime = get_seconds();
if ( ( inode = _devfs_get_vfs_inode (dir->i_sb, de, dentry) ) == NULL )
return -ENOMEM;
DPRINTK (DEBUG_I_MKNOD, ": new VFS inode(%u): %p dentry: %p\n",
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:25 EST