Re: Linux v2.5.48

From: William Lee Irwin III (wli@holomorphy.com)
Date: Mon Nov 18 2002 - 01:57:05 EST


On Sun, Nov 17, 2002 at 08:41:05PM -0800, Linus Torvalds wrote:
> Hmm.. All over the place, best you see the changelog. Lots of small
> cleanups (remove unnecessary header files etc), but a few more fundamental
> changes too. Times in nsecs in stat64(), for example, and the
> oft-discussed kernel module loader changes..

This oopses on NUMA-Q sometime prior to TSC synch and then hangs in TSC
synch because not all cpus are responding where 2.5.47-mm3 (which
included some intermediate bk stuff) did not. This is because AP's are
taking timer interrupts before they are prepared to do so. Please apply
the following patch from Martin Bligh which resolves this issue:

Thanks,
Bill

diff -purN -X /home/mbligh/.diff.exclude virgin/arch/i386/kernel/smpboot.c noearlyirq/arch/i386/kernel/smpboot.c
--- virgin/arch/i386/kernel/smpboot.c Mon Nov 4 14:30:27 2002
+++ noearlyirq/arch/i386/kernel/smpboot.c Wed Nov 6 15:22:12 2002
@@ -419,6 +419,7 @@ void __init smp_callin(void)
          smp_store_cpu_info(cpuid);
 
         disable_APIC_timer();
+ local_irq_disable();
         /*
          * Allow the master to continue.
          */
@@ -1186,6 +1187,7 @@ int __devinit __cpu_up(unsigned int cpu)
         if (!test_bit(cpu, &cpu_callin_map))
                 return -EIO;
 
+ local_irq_enable();
         /* Unleash the CPU! */
         set_bit(cpu, &smp_commenced_mask);
         while (!test_bit(cpu, &cpu_online_map))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:20 EST