Re: Several Misc SCSI updates...

From: Alexander Viro (viro@math.psu.edu)
Date: Sun Nov 17 2002 - 16:55:26 EST


On Sun, 17 Nov 2002, Linus Torvalds wrote:

>
> On Sun, 17 Nov 2002, Doug Ledford wrote:
> >
> > Won't work. module->live is what Rusty uses to indicate that the module
> > is in the process of unloading, which is when we *do* want the attempt to
> > module_get() to fail.
>
> That's fine, as long as "module_get()" is the only thing that cares. Just
> make it go "live" early as you indicate, and everybody should be happy. I
> certainly agree that it should be illegal to do more module_get()'s once
> we've already started unloading..

On the unload side it's OK. module_get() also breaks during _init_ and that's
the problem. IOW, you'll need to make every block device driver to set ->live
manually. Smells like a wrong API...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:19 EST