Re: NMI handling rework for x86

From: John Levon (
Date: Fri Nov 15 2002 - 00:12:07 EST

On Thu, Nov 14, 2002 at 10:30:16PM -0600, Corey Minyard wrote:

> Since a lot of things are hacking into this code (lkcd, kdb, oprofile,
> nmi watchdog, and now my IPMI watchdog pretimeout), it would be very
> nice to get their junk out of this code and allow them to bind in
> nicely, and allow binding from modules.

I've just noticed you haven't fixed the watchdog vs. oprofile case. You
pass in the handled flag to the NMI watchdog handler, but you ignore the
value and always do the perfctr reset. You /must/ only do the reset if
handled == false, or you'll screw up oprofile when it's running.

also, the diff would be much easier to read as a separate "mv nmi.c
nmi_watchdog.c" then diff against that

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:35 EST