Re: PATCH 2.4: scsi and BLK_STATS

From: Matthias Urlichs (
Date: Tue Nov 12 2002 - 20:30:59 EST


Christoph Hellwig:
> On Tue, Nov 12, 2002 at 06:28:21PM +0100, Matthias Urlichs wrote:
> > Some people might want SCSI without block statistics...
> Probably. But your patch doesn;t gain them anything but a useless
> ifdef.. Look at include/linux/genhd.h:
Note that scsi_lib.c does not include linux/genhd.h, thus I missed
that. :-/

> static inline void req_new_io(struct request *req, int merge, int sectors) { }
> static inline void req_merged_io(struct request *req) { }
> static inline void req_finished_io(struct request *req) { }

That may be a matter of style, but I would strongly prefer these to be

#define req_new_io(_a,_b,_c) do {} while(0)
#define req_merge_io(_a) do {} while(0)
#define req_finished_io(_a) do {} while(0)

instead ... anyway, please disregard my patch and add

#include <linux/genhd.h>

in scsi/scsi_lib.c. :-/

Matthias Urlichs     |     noris network AG     |
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:27 EST