Re: [PATCH] NCR53C9x ESP: C99 designated initializers

From: Linus Torvalds (
Date: Mon Nov 11 2002 - 12:24:32 EST

On 11 Nov 2002, Alan Cox wrote:
> The stupid thing is we take the lock then call the eh function then drop
> it. You can drop the lock, wait and retake it. I need to fix a couple of
> other drivers to do a proper wait and in much the same way.

Hmm.. I wonder if the thing should disable the queue (plug it) and release
the lock before calling reset. I assume we don't want any new requests at
this point anyway, and having the low-level drivers know about stopping
the queue etc sounds like a bad idea..

Of course, I suspect that it is potentially a bad idea to have the reset
functionality at the SCSI level _at_all_. As usual, the higher layers
don't really know what is going on, and the lower levels on smarter cards
are likely to be doing the right thing on their own, no?

(Yes, we should improve the infrastructure for having per-command timeouts
etc, but the reset/abort callbacks have always been strange)


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:22 EST