Re: [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa)

From: Takashi Iwai (tiwai@suse.de)
Date: Wed Oct 23 2002 - 06:01:13 EST


Hi,

At Sat, 19 Oct 2002 01:56:53 +0900,
Osamu Tomita wrote:
>
> This is part 23/26 of patchset for add support NEC PC-9800 architecture,
> against 2.5.43.
>
> Summary:
> ALSA sound driver related modules.
> - add feature to support CS4231+OPL3 (not PNP)

Are you sure that it's really CS4231?
If it's a higher model, such as cs4232, cs4235 or cs4236, FM OPL3 is
already supported (although additional codes to opl3 module are
necessary for PC9800).

> - add hardware specific initialization.

The MPU401 hack looks odd.
I'd propose to split a PC9800 specific driver up, rather than
including bunch of ifdefs...

Regards,

-- 
Takashi Iwai <tiwai@suse.de>		SuSE Linux AG - www.suse.de
ALSA Developer				ALSA Project - www.alsa-project.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Oct 23 2002 - 22:01:03 EST